From 96f20cf6bd51e5d7db12c38afaaebb1cf0cb6760 Mon Sep 17 00:00:00 2001 From: Daniel Berteaud Date: Tue, 5 Mar 2013 23:38:31 +0100 Subject: [PATCH] send /dev/null to lvm commands stdin, this prevent this message in EL 6.4: 'fdopen() failed: Invalid argument', with lvm snapshots failing to be created or removed --- virt-backup | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/virt-backup b/virt-backup index 46fa0b9..044c675 100644 --- a/virt-backup +++ b/virt-backup @@ -598,9 +598,9 @@ sub create_snapshot{ my ($blk,$suffix) = @_; my $ret = 0; print "Running: $opts{lvcreate} -p r -s -n " . $blk . $suffix . - " -L $opts{snapsize} $blk > /dev/null 2>&1\n" if $opts{debug}; + " -L $opts{snapsize} $blk > /dev/null 2>&1 < /dev/null\n" if $opts{debug}; if ( system("$opts{lvcreate} -p r -s -n " . $blk . $suffix . - " -L $opts{snapsize} $blk > /dev/null 2>&1") == 0 ) { + " -L $opts{snapsize} $blk > /dev/null 2>&1 < /dev/null") == 0 ) { $ret = 1; open SNAPLIST, ">>$backupdir.meta/snapshots" or die "Error, couldn't open snapshot list file\n"; print SNAPLIST $blk.$suffix ."\n"; @@ -614,7 +614,7 @@ sub destroy_snapshot{ my $ret = 0; my ($snap) = @_; print "Removing snapshot $snap\n" if $opts{debug}; - if (system ("$opts{lvremove} -f $snap > /dev/null 2>&1") == 0 ){ + if (system ("$opts{lvremove} -f $snap > /dev/null 2>&1 < /dev/null") == 0 ){ $ret = 1; } return $ret;