Some coding style updates

tags/zabbix-agent-addons-0.2.65-1
Daniel Berteaud 6 years ago
parent 49f17304ad
commit 02d58e3e53
  1. 28
      zabbix_scripts/check_backuppc_sudo

@ -17,6 +17,7 @@ my $host = $ARGV[0];
my $what = $ARGV[1]; my $what = $ARGV[1];
my $bpc = BackupPC::Lib->new(); my $bpc = BackupPC::Lib->new();
my @backups = $bpc->BackupInfoRead($host); my @backups = $bpc->BackupInfoRead($host);
my $mainConf = $bpc->ConfigDataRead(); my $mainConf = $bpc->ConfigDataRead();
my $hostConf = $bpc->ConfigDataRead($host); my $hostConf = $bpc->ConfigDataRead($host);
@ -34,8 +35,7 @@ for ( my $i = 0 ; $i < @backups ; $i++ ) {
$fullSize = $backups[$i]{size}; $fullSize = $backups[$i]{size};
$fullDur = $backups[$i]{endTime} - $backups[$i]{startTime}; $fullDur = $backups[$i]{endTime} - $backups[$i]{startTime};
} }
} }else {
else {
$incrCnt++; $incrCnt++;
if ( $incrAge < 0 || $backups[$i]{startTime} > $incrAge ) { if ( $incrAge < 0 || $backups[$i]{startTime} > $incrAge ) {
$incrAge = $backups[$i]{startTime}; $incrAge = $backups[$i]{startTime};
@ -44,14 +44,12 @@ for ( my $i = 0 ; $i < @backups ; $i++ ) {
} }
if ( $fullAge > $incrAge && $fullAge >= 0 ) { if ( $fullAge > $incrAge && $fullAge >= 0 ) {
$lastAge = $fullAge; $lastAge = $fullAge;
} } else {
else {
$lastAge = $incrAge; $lastAge = $incrAge;
} }
if ( $lastAge < 0 ) { if ( $lastAge < 0 ) {
$lastAge = ""; $lastAge = "";
} } else {
else {
$lastAge = sprintf("%.1f", (time - $lastAge) / (24 * 3600)); $lastAge = sprintf("%.1f", (time - $lastAge) / (24 * 3600));
} }
$lastXferErrors = $backups[@backups-1]{xferErrs} if ( @backups ); $lastXferErrors = $backups[@backups-1]{xferErrs} if ( @backups );
@ -59,23 +57,17 @@ $maxErrors = $conf->{MaxXferError} if (defined $conf->{MaxXferError});
if ($what eq 'errors'){ if ($what eq 'errors'){
print $lastXferErrors; print $lastXferErrors;
} } elsif ($what eq 'max_errors'){
elsif ($what eq 'max_errors'){
print $maxErrors; print $maxErrors;
} } elsif ($what eq 'age'){
elsif ($what eq 'age'){
print $lastAge; print $lastAge;
} } elsif ($what eq 'size'){
elsif ($what eq 'size'){
print $fullSize; print $fullSize;
} } elsif ($what eq 'duration'){
elsif ($what eq 'duration'){
print $fullDur; print $fullDur;
} } elsif ($what eq 'notify'){
elsif ($what eq 'notify'){
print $conf->{EMailNotifyOldBackupDays}; print $conf->{EMailNotifyOldBackupDays};
} } else{
else{
print<<"EOF"; print<<"EOF";
Usage: $0 <host> [errors|age|size|duration] Usage: $0 <host> [errors|age|size|duration]

Loading…
Cancel
Save