Enhance backuppc reporting script

Including reporting the new file size, and sending all the info at once in JSON format

zabbix_scripts/check_backuppc_sudo

@@ -27,50 +27,68 @@ my $fullAge = $incrAge = $lastAge = -1;
 my $lastXferErrors = 0;
 my $maxErrors = 0;
 
-for ( my $i = 0 ; $i < @backups ; $i++ ) {
+if ( @backups ) {
+  for ( my $i = 0 ; $i < @backups ; $i++ ) {
     if ( $backups[$i]{type} eq "full" ) {
-        $fullCnt++;
+      $fullCnt++;
-        if ( $fullAge < 0 || $backups[$i]{startTime} > $fullAge ) {
+      if ( $fullAge < 0 || $backups[$i]{startTime} > $fullAge ) {
-            $fullAge  = $backups[$i]{startTime};
+        $fullAge  = $backups[$i]{startTime};
-            $fullSize = $backups[$i]{size};
+        $fullSize = $backups[$i]{size};
-            $fullDur  = $backups[$i]{endTime} - $backups[$i]{startTime};
+        $fullDur  = $backups[$i]{endTime} - $backups[$i]{startTime};
-        }
+      }
-    }else {
+    } else {
-        $incrCnt++;
+      $incrCnt++;
-        if ( $incrAge < 0 || $backups[$i]{startTime} > $incrAge ) {
+      if ( $incrAge < 0 || $backups[$i]{startTime} > $incrAge ) {
-            $incrAge = $backups[$i]{startTime};
+        $incrAge = $backups[$i]{startTime};
-        }
+      }
     }
-}
+  }
-if ( $fullAge > $incrAge && $fullAge >= 0 )  {
+  if ( $fullAge > $incrAge && $fullAge >= 0 )  {
     $lastAge = $fullAge;
-} else {
+  } else {
     $lastAge = $incrAge;
-}
+  }
-if ( $lastAge < 0 ) {
+  if ( $lastAge < 0 ) {
     $lastAge = "";
-} else {
+  } else {
     $lastAge = sprintf("%.1f", (time - $lastAge) / (24 * 3600));
+  }
+  $lastXferErrors = $backups[@backups-1]{xferErrs};
+  $lastSizeNew    = $backups[@backups-1]{sizeNew};
+  $lastDuration   = $backups[@backups-1]{endTime} - $backups[@backups-1]{startTime};
+  $lastType       = $backups[@backups-1]{type};
 }
-$lastXferErrors = $backups[@backups-1]{xferErrs} if ( @backups );
+
 $maxErrors = $conf->{MaxXferError} if (defined $conf->{MaxXferError});
 
-if ($what eq 'errors'){
+if ($what eq 'errors') {
-    print $lastXferErrors;
+  print $lastXferErrors;
-} elsif ($what eq 'max_errors'){
+} elsif ($what eq 'max_errors') {
-    print $maxErrors;
+  print $maxErrors;
-} elsif ($what eq 'age'){
+} elsif ($what eq 'age') {
-    print $lastAge;
+  print $lastAge;
-} elsif ($what eq 'size'){
+} elsif ($what eq 'size') {
-    print $fullSize;
+  print $fullSize;
-} elsif ($what eq 'duration'){
+} elsif ($what eq 'duration') {
-    print $fullDur;
+  print $lastDuration;
-} elsif ($what eq 'notify'){
+} elsif ($what eq 'notify') {
-    print $conf->{EMailNotifyOldBackupDays};
+  print $conf->{EMailNotifyOldBackupDays};
-} else{
+} elsif ($what eq 'all') {
+  print to_json(
+    {
+      max_errors    => $maxErrors,
+      last_age      => $lastAge,
+      full_size     => $fullSize,
+      new_size      => $lastSizeNew,
+      full_duration => $fullDur,
+      duration      => $lastDuration,
+      last_type     => $lastType
+    }
+  );
+} else {
   print<<"EOF";
 
-Usage: $0 <host> [errors|age|size|duration]
+Usage: $0 <host> [errors|age|size|duration|all]
 
 EOF
 }