fws
/
virt-backup
4
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

send /dev/null to lvm commands stdin, this prevent this message in EL 6.4: 'fdopen() failed: Invalid argument', with lvm snapshots failing to be created or removed

Browse Source
tags/virt-backup-0.2.12-1
Daniel Berteaud 12 years ago
parent dec692ab30
commit 96f20cf6bd
1 changed files with 3 additions and 3 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 6
      virt-backup

6
virt-backup
Unescape View File

@ -598,9 +598,9 @@ sub create_snapshot{
my ($blk,$suffix) = @_; my ($blk,$suffix) = @_;
my $ret = 0; my $ret = 0;
print "Running: $opts{lvcreate} -p r -s -n " . $blk . $suffix . print "Running: $opts{lvcreate} -p r -s -n " . $blk . $suffix .
" -L $opts{snapsize} $blk > /dev/null 2>&1\n" if $opts{debug}; " -L $opts{snapsize} $blk > /dev/null 2>&1 < /dev/null\n" if $opts{debug};
if ( system("$opts{lvcreate} -p r -s -n " . $blk . $suffix . if ( system("$opts{lvcreate} -p r -s -n " . $blk . $suffix .
" -L $opts{snapsize} $blk > /dev/null 2>&1") == 0 ) { " -L $opts{snapsize} $blk > /dev/null 2>&1 < /dev/null") == 0 ) {
$ret = 1; $ret = 1;
open SNAPLIST, ">>$backupdir.meta/snapshots" or die "Error, couldn't open snapshot list file\n"; open SNAPLIST, ">>$backupdir.meta/snapshots" or die "Error, couldn't open snapshot list file\n";
print SNAPLIST $blk.$suffix ."\n"; print SNAPLIST $blk.$suffix ."\n";
@ -614,7 +614,7 @@ sub destroy_snapshot{
my $ret = 0; my $ret = 0;
my ($snap) = @_; my ($snap) = @_;
print "Removing snapshot $snap\n" if $opts{debug}; print "Removing snapshot $snap\n" if $opts{debug};
if (system ("$opts{lvremove} -f $snap > /dev/null 2>&1") == 0 ){ if (system ("$opts{lvremove} -f $snap > /dev/null 2>&1 < /dev/null") == 0 ){
$ret = 1; $ret = 1;
} }
return $ret; return $ret;

Write Preview
Loading…
Cancel
Save